Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverts schema, indents method, removes commented out test #206

Merged
merged 1 commit into from
Dec 9, 2014

Conversation

mejackreed
Copy link
Member

  • addresses @gravesm comment about try/catch js block.
  • removes commented out test (my cruft)
  • indents method (my comment)
  • modifies changed code to AirBnb styleguide results.js
  • reverts submodule commit to master

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cb8755d on iiif-viewer-remove-cruft into 7a10fca on iiif-viewer.

@eliotjordan
Copy link
Member

Nice cleanup. I think the submodule issue was the result of rebasing too late in the evening. :)

eliotjordan added a commit that referenced this pull request Dec 9, 2014
reverts schema, indents method, removes commented out test
@eliotjordan eliotjordan merged commit 8e6544b into iiif-viewer Dec 9, 2014
@mejackreed mejackreed deleted the iiif-viewer-remove-cruft branch December 9, 2014 18:58
@drh-stanford
Copy link

@mejackreed what was the issue with the schema revert?

@mejackreed
Copy link
Member Author

Elliot's pull request inadvertently changed the Schema commit, I changed it back.

On Dec 10, 2014, at 2:17 PM, Darren Hardy notifications@github.com wrote:

@mejackreed what was the issue with the schema revert?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants