Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case by case fixtures modify #228

Merged
merged 2 commits into from
Dec 13, 2014

Conversation

mejackreed
Copy link
Member

Moves fixtures to specific directories.

JSON docs under spec/fixtures/solr_documents will be indexed for use in feature testing/development

JSON docs under spec/fixtures/test_cases could be used instead of creating json records in specific unit tests. For example see: https://github.com/geoblacklight/geoblacklight/blob/master/spec/lib/geoblacklight/references_spec.rb#L6

Instead of creating a a record for each of these tests, json files could be used or this could be included in a Ruby class. Creating ticket #227 for evaluating whether or not to do this

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1ab867f on case-by-case-fixtures-modify into 5b35df3 on case-by-case-fixtures.

@mejackreed
Copy link
Member Author

Also I removed the dct_references_generate and dct_references_spec as it seemed that these were out of date and could be managed now using the specific json files included as fixtures.

drh-stanford pushed a commit that referenced this pull request Dec 13, 2014
@drh-stanford drh-stanford merged commit 0d30162 into case-by-case-fixtures Dec 13, 2014
@drh-stanford drh-stanford deleted the case-by-case-fixtures-modify branch December 13, 2014 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants