Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rubocop and add a todo file #600

Merged
merged 2 commits into from
Jul 26, 2018
Merged

update rubocop and add a todo file #600

merged 2 commits into from
Jul 26, 2018

Conversation

mejackreed
Copy link
Member

Resolves a vulnerability in older versions of Rubocop

@eliotjordan
Copy link
Member

I reworked this with a commit to use the bixby gem to manage rubocop. It's stable, community supported, and offers sensible defaults.

@coveralls
Copy link

coveralls commented Jul 24, 2018

Coverage Status

Coverage remained the same at 96.062% when pulling addfdcf on update-rubocop into 8fa62b7 on master.

@eliotjordan
Copy link
Member

eliotjordan commented Jul 25, 2018

@mejackreed Any thoughts on this? I can go back to a straight rubocop solution if that feels better. We should do something, though, as the current setup has that security vulnerability and I'm getting errors related to rspec (we're missing require: rubocop-rspec in the settings file):

Warning: unrecognized cop RSpec/FilePath found in /Users/eliotj/Documents/Repositories/geoblacklight/.rubocop.yml
Warning: unrecognized cop RSpec/DescribeClass found in /Users/eliotj/Documents/Repositories/geoblacklight/.rubocop.yml
Warning: unrecognized cop RSpec/AnyInstance found in /Users/eliotj/Documents/Repositories/geoblacklight/.rubocop.yml

@mejackreed
Copy link
Member Author

No strong feelings really. As long as it works and people are 🆗 with it, i'm good. I don't ever use bixby for anything so defer to your experience here.

@jrgriffiniii jrgriffiniii merged commit 57d507f into master Jul 26, 2018
Summer Code Sprint 2018 automation moved this from Review to Done Jul 26, 2018
@jrgriffiniii jrgriffiniii deleted the update-rubocop branch July 26, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants