Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peg thor version >= 19.0 to fix issue with test app generation #626

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Peg thor version >= 19.0 to fix issue with test app generation #626

merged 1 commit into from
Jul 24, 2018

Conversation

eliotjordan
Copy link
Member

  • Prevents installation of thor 18.0, fixing a known issue with the rails app generator.
  • Backwards compatible to Rails 3.2 if necessary.

Closes #625

mejackreed
mejackreed approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mejackreed mejackreed merged commit 16f73f8 into master Jul 24, 2018
@mejackreed mejackreed deleted the 625-upgrade-thor branch July 24, 2018 16:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.057% when pulling 5efafb5 on 625-upgrade-thor into 73240f3 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejackreed mejackreed mejackreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EngineCart will not generate test app
3 participants
@eliotjordan @coveralls @mejackreed