Leaflet upgrade for master #679
Conversation
ewlarson
commented
Jul 31, 2018
ewlarson
commented
- Bump leaflet-rails, esri-leaflet, and leaflet-iiif to their most current release versions
- Fix upgrade issues for the opacity slider
- Make small leaflet api adjustments for esri viewer
- Set index_map labels natively
- Drop leaflet-label-src dependency
|
@ewlarson This PR needs a rebase to get the circle ci running. |
|
Do we want to ship a 1.9 release without the breaking changes first? |
|
@mejackreed Are suggesting this should be a 1.10 release or it should released as part of 2.0 with the blacklight 7 updates? |
|
@mejackreed What changes here break current functionality? |
|
I was thinking about the leaflet version upgrade potentially being troublesome for some. Perhaps its not though. |
|
I believe all Geoblacklight leaflet/map functionality is unbroken here -- test suite items are good. If you've added a third-party fullscreen plugin or otherwise, those may potentially break, but you've committed yourself to that path already. |
* Bump leaflet-rails, esri-leaflet, and leaflet-iiif to their most current release versions * Fix upgrade issues for the opacity slider * Make small leaflet api adjustments for esri viewer * Drop leaflet-label-src dependency * Set index_map labels natively
Fixes #557 For AJAX POST requests, we need to pass along Rails' CSRF token in Rails 5.1+
eliotjordan
force-pushed
the
leaflet-upgrade-for-master
branch
from
15df1e4
to
daf98c2
Compare
|
I'm not sure what was up with CI, so I rebased again and force pushed. Hopefully that helps. |
jrgriffiniii
requested review from
jrgriffiniii
and removed request for
jrgriffiniii
