[WIP] fixes flipping bbox #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinach
force-pushed
the
616-flipped-bbox
branch
2 times, most recently
from
a2567b4
to
cbd5b0d
Compare
christinach
force-pushed
the
616-flipped-bbox
branch
from
cbd5b0d
to
cb3ab31
Compare
|
The PR fixes the flipping box because of coordinates crossing the antimeridian but will not fix coords that are passed incorrectly in the solr_geom field. |
christinach
force-pushed
the
616-flipped-bbox
branch
3 times, most recently
from
1d1a175
to
76233ae
Compare
|
@karenmajewicz PR will update the solr_geom for https://github.com/geoblacklight/geoblacklight/pull/697/files#diff-07cc93333019091171bf8ad6d9894911. With the updated fixture it will look like: |
|
The show page for the area of Alaska that crosses the antimeridian because of the "solr_geom": "ENVELOPE(-179.9999845, 179.9993566, 71.9545187, 43.0532272)", |
christinach
force-pushed
the
616-flipped-bbox
branch
from
76233ae
to
ffe609e
Compare
|
@christinach This could use a rebase with master. And perhaps squashing those three commits into one? |
christinach
force-pushed
the
616-flipped-bbox
branch
from
ffe609e
to
3797b36
Compare
christinach
force-pushed
the
616-flipped-bbox
branch
from
3797b36
to
06b1b1b
Compare
christinach
force-pushed
the
616-flipped-bbox
branch
from
06b1b1b
to
c41dd83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to test some more fixtures before removing the WIP