-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 324 bboxrelevancy #765
Conversation
solr/conf/schema.xml
Outdated
</schema> | ||
|
||
<!-- for bbox value --> | ||
<copyField source="*_geom" dest="*_bboxtype"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assume that all *_geom
fields can be copied into _*bboxtype
? If I provide point data here, what happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't know... potentially "bad things". Instead of the wildcard copy, what specific field should be copied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to test that out since that is something we should evaluate. If this copying over doesn't work for point fields, don't know if there is such a thing as a conditional copy possible in schema (i.e. If solr_geom is bbox-compatible, copy over)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out current schema uses the "ENVELOPE WKT" syntax in the solr_geom
field which will copy over fine. Instead of copying all _geom
fields, how about just solr_geom
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hudajkhan @mejackreed @eliotjordan We are all on the same page here. Let's limit the copy to just the solr_geom field. Want to push that commit @hudajkhan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will make this change now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a big difference in the quality of spatial search results. Thanks for all the hard work on this.
a790c31
to
88b7ade
Compare
…able via the presence of Settings.OVERLAP_RATIO_BOOST. When a bbox param is present, the Settings.OVERLAP_RATIO_BOOST value will boost results based on the overlap ratio of the result bboxes. Includes a modification to our Solr schema to include a _bboxtype fieldtype. Requires Solr 7.4+ Co-Authored-By: hudajkhan <hudajkhan@users.noreply.github.com>
88b7ade
to
1d9ff42
Compare
This PR adds optional spatial search overlapRatio relevancy support. Configurable via the presence of Settings.OVERLAP_RATIO_BOOST.
When a bbox param is present, the Settings.OVERLAP_RATIO_BOOST value will boost results based on the overlap ratio of the result bboxes.
Includes a modification to our Solr schema to include a _bboxtype fieldtype. Requires Solr 7.4+
Thanks to:
@hudajkhan / Feature development
@ewlarson / Rspec tests