Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates link to fix related record search #784

Merged
merged 3 commits into from
May 20, 2019
Merged

updates link to fix related record search #784

merged 3 commits into from
May 20, 2019

Conversation

tampakis
Copy link
Contributor

See geobtaa/geoportal#120 and pulibrary/pulmap#604. Thanks for the fix @ewlarson!

Hoping to backport this.

mejackreed
mejackreed reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the fix for this! Is it possible to add a failing now passing test?

@coveralls
Copy link

coveralls commented Mar 25, 2019 •
edited

Coverage Status

Coverage increased (+0.004%) to 96.671% when pulling 66376c5 on relations-link-fix into e252cb5 on master.

@tampakis tampakis force-pushed the relations-link-fix branch 4 times, most recently from ec4eb03 to fb1f2f4 Compare March 27, 2019 12:54
@jrgriffiniii jrgriffiniii added this to Review in GeoBlacklight May 16, 2019
eliotjordan
eliotjordan approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@eliotjordan eliotjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just need to appease rubocop.

Single quotes at spec/features/search_spec.rb:11

@mejackreed
Copy link
Member

Thanks @eliotjordan .. Updated now

@eliotjordan eliotjordan merged commit 534b1b1 into master May 20, 2019
GeoBlacklight automation moved this from Review to Done May 20, 2019
@eliotjordan eliotjordan deleted the relations-link-fix branch May 20, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejackreed mejackreed mejackreed left review comments

@eliotjordan eliotjordan eliotjordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
GeoBlacklight
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tampakis @coveralls @mejackreed @eliotjordan