Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark spec pending for external failure cause due to cors #788

Merged
merged 3 commits into from
May 16, 2019
Merged

Conversation

mejackreed
Copy link
Member

@mejackreed mejackreed commented May 11, 2019

Marks a spec pending (and incorporates changes from #790) for a failure that happens also locally from an external service no longer supporting cors.

@coveralls
Copy link

coveralls commented May 11, 2019

Coverage Status

Coverage decreased (-0.004%) to 96.667% when pulling f94db9c on fix-build into e94d798 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.671% when pulling d4b0129 on fix-build into e94d798 on master.

@jrgriffiniii
Copy link
Collaborator

jrgriffiniii commented May 11, 2019

I see no RSpec failures for https://circleci.com/gh/geoblacklight/geoblacklight/886

@jrgriffiniii jrgriffiniii self-requested a review May 11, 2019 01:54
@jrgriffiniii
Copy link
Collaborator

I'm trying this approach: master...jrgriffiniii:fix-build-jrgriffiniii

@jrgriffiniii
Copy link
Collaborator

https://circleci.com/gh/jrgriffiniii/geoblacklight/254 passed, but when I attempt to use Solr 8 for this, it gives me an error for the solr.StandardFilterFactory when creating the Collection from the configuration.

@jrgriffiniii
Copy link
Collaborator

I have offered a solution with #790. I'm uncertain as to what triggered the failing solr_wrapper tasks, but this should ensure that Solr does not introduce any problems for the build.

Modifies the CircleCI configuration to use Docker containers for Solr
@cbeer cbeer merged commit e24a4c3 into master May 16, 2019
@jrgriffiniii
Copy link
Collaborator

Thank you @cbeer

@cbeer cbeer deleted the fix-build branch May 16, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants