Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure the display of the Carto and ArcGIS links #837

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Configure the display of the Carto and ArcGIS links #837

merged 3 commits into from
Aug 6, 2019

Conversation

christinach
Copy link
Collaborator

closes #810

eliotjordan
eliotjordan requested changes Aug 6, 2019
View reviewed changes
Copy link
Member

@eliotjordan eliotjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment about default value for the settings, this looks good.

app/helpers/geoblacklight_helper.rb Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.719% when pulling 62bbc49 on 810-configure-display-carto-arcgis into 0b9fdb5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.715% when pulling 62bbc49 on 810-configure-display-carto-arcgis into 0b9fdb5 on master.

@mejackreed mejackreed merged commit 96a201d into master Aug 6, 2019
@mejackreed mejackreed deleted the 810-configure-display-carto-arcgis branch August 6, 2019 18:22
@mejackreed mejackreed mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliotjordan eliotjordan eliotjordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to configure display of carto and ArcGIS export links
4 participants
@christinach @coveralls @eliotjordan @mejackreed