Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty data attributes #20

Closed
missinglink opened this issue Jan 19, 2022 · 1 comment · Fixed by geocodeearth/core-js#9
Closed

empty data attributes #20

missinglink opened this issue Jan 19, 2022 · 1 comment · Fixed by geocodeearth/core-js#9
Assignees
@mxlje

Comments

@missinglink
Copy link
Contributor

empty data attributes generate empty querystring params, eg:

<ge-autocomplete sources="" /> will add ?sources= to the querystring.

use of this library from templating is easier if the data attributes are always rendered in the HTML but only populated when required.

this ticket is to investigate solutions to detecting empty data attributes and avoiding generating querystring params.
@mxlje mxlje mentioned this issue Feb 21, 2022
Merged
@mxlje
Copy link
Contributor

mxlje commented Feb 21, 2022 •
edited

This has been fixed in core-js v0.0.8 and is included in the latest release v0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxlje mxlje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: params: exclude '' (empty string) geocodeearth/core-js
2 participants
@missinglink @mxlje