fix: params: exclude ''

fix geocodeearth/autocomplete-element#20
geocodeearth · Feb 21, 2022 · 23f271a · 23f271a
1 parent 60b4dd0
commit 23f271a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/api/autocomplete/params.test.ts b/src/api/autocomplete/params.test.ts
@@ -1,10 +1,10 @@
 import { Params, createQuery } from './params'
 
-test('paramsToQuery excludes empty fields', () => {
+test('createQuery excludes empty fields', () => {
   const params: Params = {
     lang: 'de',
     layers: undefined,
-    sources: undefined
+    sources: []
   }
 
   expect(createQuery('ge-abcabccbacbacbac', 'berlin', params)).toStrictEqual({

diff --git a/src/api/autocomplete/params.ts b/src/api/autocomplete/params.ts
@@ -68,6 +68,6 @@ export const createQuery = (apiKey: string, text: string, params: Params = {}):
     'boundary.rect.max_lon': params.boundary?.rect?.maxLon?.toString()
   }
 
-  // don’t return empty values (null & undefined) as to not have ?size=undefined in the actual URL query
-  return Object.fromEntries(Object.entries(q).filter(([_, v]) => v != null)) as Record<string, string>
+  // don’t return empty values (null, undefined, '') as to not have ?size=undefined or empty values in the actual URL query
+  return Object.fromEntries(Object.entries(q).filter(([_, v]) => v != null && v !== '')) as Record<string, string>
 }