programatically trigger searches by setting value attribute
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, how/where is this |
|
That is an optional prop that can be passed in as The custom element uses it to trigger the autocomplete-element/src/index.js Line 33 in 6bddec3 this was the case before this PR already though, that hasn’t changed. |
if the objects are passed to useMemo as dependencies directly the internal equality check fails, which defeats the purpose of useMemo as it recalculates the client on every render. That then also generates a new search & debounced search function, which breaks the debouncing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to set the
valueattribute on the custom element to trigger a search with that value. The attribute can be set using the nativesetAttributeAPI, but getters and setters are also available for an even cleaner api.In addition to being able to set the
valueattribute programmatically it can also be set initially, which will trigger the search as soon as the element is initialized.