Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 attributes #302

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

pierredup
Copy link
Contributor

@pierredup pierredup commented Feb 1, 2021

This adds support to use PHP 8 attributes for an entity instead of annotations.

E.G

use Bazinga\GeocoderBundle\Mapping\Annotations as Geocoder;

#[Geocoder\Geocodeable()]
class User
{
    #[Geocoder\Address()]
    private $address;

    #[Geocoder\Latitude()]
    private $latitude;

    #[Geocoder\Longitude()]
    private $longitude;
}

@norkunas
Copy link
Member

norkunas commented Feb 2, 2021

Looks good, please squash commits :)

@norkunas norkunas merged commit 3460bbf into geocoder-php:master Feb 2, 2021
@norkunas
Copy link
Member

norkunas commented Feb 2, 2021

Thank you :)

@pierredup pierredup deleted the php8-attributes branch February 2, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants