Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Google Maps] Fix issue with duplicated SubLocalityLevels #1174

Merged
merged 9 commits into from
Apr 14, 2023
Merged

[Google Maps] Fix issue with duplicated SubLocalityLevels #1174

merged 9 commits into from
Apr 14, 2023

Conversation

jbelien
Copy link
Member

@jbelien jbelien commented Feb 19, 2023 •
edited
Loading

  • Refactor withSubLocalityLevels() function to combine names and codes if sublocality_level_* is duplicated.
  • Add test
  • Update PHPDoc in GoogleMapsTest.php for consistency

Fix #1173
Fix #793 (already fixed by #943)

@jbelien jbelien added the bug label Feb 19, 2023
@jbelien jbelien self-assigned this Feb 19, 2023
@jbelien jbelien requested a review from Nyholm February 19, 2023 17:04
@jbelien jbelien mentioned this pull request Feb 19, 2023
Closed
@jbelien jbelien linked an issue Feb 19, 2023 that may be closed by this pull request
Administrative level 4 is defined twice #793
Closed
@jbelien jbelien merged commit 9f65578 into master Apr 14, 2023
@jbelien jbelien deleted the google/duplicate-levels branch April 14, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees

@jbelien jbelien

Labels
bug provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Google] Administrative level 1 is defined twice Administrative level 4 is defined twice
1 participant
@jbelien