Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we dont include multiple vendor folders #934

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@Nyholm
Copy link
Member

Nyholm commented Jan 21, 2019

This will fail until php-http/discovery:1.6 is released (Any hour now).

This will help #933

@jbelien

This comment has been minimized.

Copy link
Member

jbelien commented Feb 4, 2019

Just restarted the build since php-http/discovery:1.6 is released.

Build still fails but it's due to "Array to string conversion" in PHP7.2. I'll fix it in a different PR ASAP ! 😃

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Feb 4, 2019

It seams allright... Or, we got a minor issue with out test code on "deps=high". And on "deps=low" we should make sure to bump the version in discovery.

@jbelien

This comment has been minimized.

Copy link
Member

jbelien commented Feb 4, 2019

Oh, that's weird, I don't see the "Array to string conversion" in the Travis log ...
Well, not sure how to fix this then :/

@Nyholm Nyholm referenced this pull request Feb 4, 2019

Merged

Make sure we support PSR-18 #16

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Feb 4, 2019

I believe if we merge and tag this: geocoder-php/provider-integration-tests#16

Then this PR will finally be happy =)

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Feb 6, 2019

Thank you

@Nyholm Nyholm merged commit 80da39e into geocoder-php:master Feb 6, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Nyholm Nyholm deleted the Nyholm:phpunit branch Feb 6, 2019

@jbelien

This comment has been minimized.

Copy link
Member

jbelien commented Feb 6, 2019

Awesome!
We're back in the green :P

@Nyholm

This comment has been minimized.

Copy link
Member Author

Nyholm commented Feb 6, 2019

Wohoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.