Make sure we dont include multiple vendor folders #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just restarted the build since php-http/discovery:1.6 is released. Build still fails but it's due to "Array to string conversion" in PHP7.2. I'll fix it in a different PR ASAP ! 😃 |
|
It seams allright... Or, we got a minor issue with out test code on "deps=high". And on "deps=low" we should make sure to bump the version in discovery. |
|
Oh, that's weird, I don't see the "Array to string conversion" in the Travis log ... |
|
I believe if we merge and tag this: geocoder-php/provider-integration-tests#16 Then this PR will finally be happy =) |
|
Thank you |
|
Awesome! |
|
Wohoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fail until php-http/discovery:1.6 is released (Any hour now).
This will help #933