Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(provider): deprecate mapzen provider #963

Merged
merged 1 commit into from Jun 13, 2019
Merged

chore(provider): deprecate mapzen provider #963

merged 1 commit into from Jun 13, 2019

Conversation

atymic
Copy link
Member

@atymic atymic commented May 30, 2019

This PR deprecates the mapzen provider by:

  • adding @deprecated annotations to the class & constructor (which will warn people using IDEs)
  • Updating the readme and changelog to communicate the deprecation
  • Removing it from the main readme.

@Nyholm will also need to mark the package as abandoned on packagist.

@atymic atymic force-pushed the mapzen-depreciation branch 3 times, most recently from 8f9f8bc to 1617237 Compare May 31, 2019 00:03
@jbelien jbelien requested a review from Nyholm May 31, 2019 07:43
@atymic
Copy link
Member Author

atymic commented Jun 13, 2019

Sorry to bother you @Nyholm, did you get a chance to look at this?
Thanks :)

Nyholm
Nyholm approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I'll update packagist.

@Nyholm Nyholm merged commit cd34e16 into geocoder-php:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
documentation provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atymic @Nyholm @jbelien