Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial laravel five one #26

Closed
wants to merge 2 commits into from
Closed

Trial laravel five one #26

wants to merge 2 commits into from

Conversation

Keoghan
Copy link

@Keoghan Keoghan commented Jun 5, 2015

Hi -

I have been trialling Laravel 5.1 - and also using your package - this is a simple update to composer.json to enable it to be installed. All appears fine so far within my relatively limited use-case.

Tweak to allow Laravel 5.1.
Allow range of Laravel versions (5.0 and 5.1)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.3% when pulling 96727b6 on konsulting:trialLaravelFiveOne into afb13da on geocoder-php:master.

@devinfd
Copy link

devinfd commented Jun 9, 2015

cant update to laravel 5.1 until this is pulled in

@martinbean
Copy link

I’m in the same boat. I have a Laravel 5.1 app I want to use this in, but this package’s requirements are locked to 5.0.x

@Keoghan
Copy link
Author

Keoghan commented Jun 10, 2015

In the meantime folks, you're welcome to use my Fork. Apologies if you already know:

In composer.json, add

"repositories": [
     {
       "type": "vcs",
       "url": "https://github.com/konsulting/GeocoderLaravel"
     }
  ]

and change the requirement

"require" :
...
"toin0u/geocoder-laravel": "dev-trialLaravelFiveOne",
...

@mattsears18
Copy link

Thanks @Keoghan! I didn't realize that was possible.

@Keoghan
Copy link
Author

Keoghan commented Jun 25, 2015

No problem @mattsears18 - comes in handy once in a while!

@mikefrancis
Copy link

What's the progress on this?

@willdurand
Copy link
Member

Should be fixed in 0.6.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants