Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getRating to return null #4

Closed
wants to merge 1 commit into from
Closed

Conversation

csrui
Copy link

@csrui csrui commented Aug 4, 2022

The getRating() return signature is not according to the documentation.
This change would fix this.

The `getRating()` return signature is not according to the documentation. 
This change would fix this.
@jbelien
Copy link
Member

jbelien commented Aug 5, 2022

Hello @csrui !
Thank you for your contribution 👍

This is a read-only repository.
Could you submit your PR to our main repository: https://github.com/geocoder-php/Geocoder/tree/master/src/Provider/GoogleMapsPlaces ?
Thanks.

@jbelien jbelien closed this Aug 5, 2022
@csrui
Copy link
Author

csrui commented Aug 11, 2022

I see you already have geocoder-php/Geocoder#1073 that would fix this.

@csrui csrui deleted the patch-1 branch August 11, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants