Skip to content

Commit

Permalink
Enable PHP 8.0 support (#1102)
Browse files Browse the repository at this point in the history
* Enable PHP 8.0 support

* Add GitHub Actions

* Upgrade php-http/curl-client + php-http/httplug

* Upgrade PHPUnit

* Drop PHP 7.2 support

* Update GitHub Actions

Remove PHP 7.2

* Update Travis CI

Remove PHP 7.2

* Drop PHP 7.2 support
  • Loading branch information
jbelien committed Dec 19, 2020
1 parent de44e1c commit d85dd9c
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 33 deletions.
28 changes: 12 additions & 16 deletions Tests/HostIpTest.php
Expand Up @@ -31,12 +31,11 @@ public function testGetName()
$this->assertEquals('host_ip', $provider->getName());
}

/**
* @expectedException \Geocoder\Exception\UnsupportedOperation
* @expectedExceptionMessage The Geocoder\Provider\HostIp\HostIp provider does not support Street addresses.
*/
public function testGeocodeWithAddress()
{
$this->expectException(\Geocoder\Exception\UnsupportedOperation::class);
$this->expectExceptionMessage('The Geocoder\Provider\HostIp\HostIp provider does not support Street addresses.');

$provider = new HostIp($this->getMockedHttpClient());
$provider->geocodeQuery(GeocodeQuery::create('10 avenue Gambetta, Paris, France'));
}
Expand All @@ -62,12 +61,11 @@ public function testGeocodeWithLocalhostIPv4()
$this->assertEquals('localhost', $result->getCountry()->getName());
}

/**
* @expectedException \Geocoder\Exception\UnsupportedOperation
* @expectedExceptionMessage The HostIp provider does not support IPv6 addresses.
*/
public function testGeocodeWithLocalhostIPv6()
{
$this->expectException(\Geocoder\Exception\UnsupportedOperation::class);
$this->expectExceptionMessage('The HostIp provider does not support IPv6 addresses.');

$provider = new HostIp($this->getMockedHttpClient());
$provider->geocodeQuery(GeocodeQuery::create('::1'));
}
Expand All @@ -91,22 +89,20 @@ public function testGeocodeWithRealIPv4()
$this->assertEquals('FR', $result->getCountry()->getCode());
}

/**
* @expectedException \Geocoder\Exception\UnsupportedOperation
* @expectedExceptionMessage The HostIp provider does not support IPv6 addresses.
*/
public function testGeocodeWithRealIPv6()
{
$this->expectException(\Geocoder\Exception\UnsupportedOperation::class);
$this->expectExceptionMessage('The HostIp provider does not support IPv6 addresses.');

$provider = new HostIp($this->getHttpClient());
$provider->geocodeQuery(GeocodeQuery::create('::ffff:88.188.221.14'));
}

/**
* @expectedException \Geocoder\Exception\UnsupportedOperation
* @expectedExceptionMessage The HostIp provider is not able to do reverse geocoding.
*/
public function testReverse()
{
$this->expectException(\Geocoder\Exception\UnsupportedOperation::class);
$this->expectExceptionMessage('The HostIp provider is not able to do reverse geocoding.');

$provider = new HostIp($this->getMockedHttpClient());
$provider->reverseQuery(ReverseQuery::fromCoordinates(1, 2));
}
Expand Down
28 changes: 12 additions & 16 deletions Tests/HostIpXmlTest.php
Expand Up @@ -31,12 +31,11 @@ public function testGetName()
$this->assertEquals('host_ip_xml', $provider->getName());
}

/**
* @expectedException \Geocoder\Exception\UnsupportedOperation
* @expectedExceptionMessage The Geocoder\Provider\HostIp\HostIpXml provider does not support Street addresses.
*/
public function testGeocodeWithAddress()
{
$this->expectException(\Geocoder\Exception\UnsupportedOperation::class);
$this->expectExceptionMessage('The Geocoder\Provider\HostIp\HostIpXml provider does not support Street addresses.');

$provider = new HostIpXml($this->getMockedHttpClient());
$provider->geocodeQuery(GeocodeQuery::create('10 avenue Gambetta, Paris, France'));
}
Expand All @@ -62,12 +61,11 @@ public function testGeocodeWithLocalhostIPv4()
$this->assertEquals('localhost', $result->getCountry()->getName());
}

/**
* @expectedException \Geocoder\Exception\UnsupportedOperation
* @expectedExceptionMessage The HostIp provider does not support IPv6 addresses.
*/
public function testGeocodeWithLocalhostIPv6()
{
$this->expectException(\Geocoder\Exception\UnsupportedOperation::class);
$this->expectExceptionMessage('The HostIp provider does not support IPv6 addresses.');

$provider = new HostIpXml($this->getMockedHttpClient());
$provider->geocodeQuery(GeocodeQuery::create('::1'));
}
Expand All @@ -92,22 +90,20 @@ public function testGeocodeWithRealIPv4()
$this->assertEquals('LV', $result->getCountry()->getCode());
}

/**
* @expectedException \Geocoder\Exception\UnsupportedOperation
* @expectedExceptionMessage The HostIp provider does not support IPv6 addresses.
*/
public function testGeocodeWithRealIPv6()
{
$this->expectException(\Geocoder\Exception\UnsupportedOperation::class);
$this->expectExceptionMessage('The HostIp provider does not support IPv6 addresses.');

$provider = new HostIpXml($this->getHttpClient());
$provider->geocodeQuery(GeocodeQuery::create('::ffff:88.188.221.14'));
}

/**
* @expectedException \Geocoder\Exception\UnsupportedOperation
* @expectedExceptionMessage The HostIp provider is not able to do reverse geocoding.
*/
public function testReverse()
{
$this->expectException(\Geocoder\Exception\UnsupportedOperation::class);
$this->expectExceptionMessage('The HostIp provider is not able to do reverse geocoding.');

$provider = new HostIpXml($this->getMockedHttpClient());
$provider->reverseQuery(ReverseQuery::fromCoordinates(1, 2));
}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -12,7 +12,7 @@
}
],
"require": {
"php": "^7.2",
"php": "^7.3 || ^8.0",
"geocoder-php/common-http": "^4.0",
"willdurand/geocoder": "^4.0"
},
Expand Down

0 comments on commit d85dd9c

Please sign in to comment.