Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to guestbook on landing page #372

Closed
Robinlovelace opened this issue Apr 11, 2019 · 10 comments
Closed

Link to guestbook on landing page #372

Robinlovelace opened this issue Apr 11, 2019 · 10 comments
Assignees

Comments

@Robinlovelace
Copy link
Collaborator

We're interested to know how the book has been used 'in the wild'. If you have a use case of something you've done using methods/ideas in the book, we'd love to hear from you! We've also put tweets mentioning the book up on our guestbook, which we intend to keep up-to-date: https://geocompr.github.io/guestbook/

@Robinlovelace
Copy link
Collaborator Author

Robinlovelace commented Nov 28, 2019

And link to this on the landing page. Will close when done.

@Robinlovelace Robinlovelace changed the title Guestbook Link to guestbook on landing page Nov 28, 2019
Robinlovelace added a commit that referenced this issue Nov 28, 2019
@markusloecher
Copy link

Dear authors,
I really like the book, thanks a lot for creating such valuable content.
I would love it even more if you could at least mention my very popular RgoogleMaps package which (i) was a pioneering contribution to rendering maps in R, and (ii) eventually led the authors of the sp package to add their great support for map plots.

Thanks,
Markus

@Robinlovelace
Copy link
Collaborator Author

Hi @markusloecher thanks for the comment! Yes it was indeed pioneering, would it fit into 'The history of R-spatial' section? https://geocompr.robinlovelace.net/intro.html#the-history-of-r-spatial

You could edit the text here, pull requests are welcome: https://github.com/Robinlovelace/geocompr/edit/main/01-introduction.Rmd

@markusloecher
Copy link

Thanks for the super fast and helpful reply.
Yes, history or R spatial section would be good or (unless my package is really outdated by now ?) in
Section @ref(other-mapping-packages) ?

Thx

@Robinlovelace
Copy link
Collaborator Author

Good point, and yes it seems the package is still in the ascendancy and from a quick comparison, similar popularity levels with tmap. I would suggest mentioning it in the history section as one of the first (right) packages for getting map visualisations anywhere on Earth (right?) and perhaps in the mapping chapter, the R’s spatial ecosystem section is more for the foundations.

dls = cranlogs::cran_downloads(package = "RgoogleMaps", from = "2009-01-01", to = Sys.Date())
plot(dls$date, dls$count)

Created on 2021-11-01 by the reprex package (v2.0.1)

@Nowosad
Copy link
Member

Nowosad commented Nov 1, 2021

Dear @markusloecher - thanks for your suggestion. I plan to work on the updates of the history section sometime this month and could add RgoogleMaps there. I would just need some justification for that (with hundreds of spatial R packages - it is impossible to mention them all).

Could you clarify your statements?

was a pioneering contribution to rendering maps in R

What was pioneering about this package? For example, the maps package allowed to display spatial data ~20 years ago...

eventually led the authors of the sp package to add their great support for map plots.

Based on CRAN archives, RgoogleMaps is several years younger than sp. Therefore, how exactly did it impact the sp package?

@Nowosad Nowosad reopened this Nov 1, 2021
@markusloecher
Copy link

Dear @Nowosad,
thanks for your message. I created RgoogleMaps in 2008 out of pure need, because at the time there simply was NO package which allowed to overlay R plots on Web based maps, such as google/OSM/bing/stamen maps.
Neither maps nor sp offered this functionality at all; instead the background was always just a white canvas. Look at the standard examples (e.g. plotting the meuse data ), and there simply was no easy way to have a real map background until a few years ago !
In that sense RgoogleMaps was pioneering and really the only tool at the time.
While sp is much older, the authors tackled OSM/google map backgrounds MUCH later.

A few years later, ggmap came out, which is a fantastic implementation into ggplot2; but if you look at the essential coordinate transformation, they were based upon/copied from RgoogleMaps.

Best
Markus

@Nowosad Nowosad self-assigned this Nov 1, 2021
@Robinlovelace
Copy link
Collaborator Author

Continuously maintained since 2009, 7 years before sf was released in 2016, impressive!

Sounds like it was the first package for overlaying map data on map tiles from online mapping services https://cran.r-project.org/src/contrib/Archive/RgoogleMaps/ and if so worthy of mention.

@markusloecher
Copy link

Thx :)
And there is a JSS paper from 2015 on it as well:
https://www.jstatsoft.org/article/view/v063i04

Best
Markus

@markusloecher
Copy link

Allow me just one more follow-up comment.
Until about 2015, the only plot of the meuse data possible was this type.

image

And RgoogleMaps allowed the following

image

And the NEWS page of the sp package states:

Changes in version 1.2-0 (2015-09-01)
..
Support for Google Earth or OpenStreetMap background maps in sp::plot and spplot. Maps returned by function GetMap in package RgoogleMaps
...
are now understood by plotting functions in sp. In particular, sp::plot now has an argument bgMap, spplot now has panel functions panel.RgoogleMaps and panel.ggmap; See demo(webmap) for examples.

Robinlovelace added a commit that referenced this issue Nov 4, 2021
Robinlovelace added a commit that referenced this issue Nov 4, 2021
github-actions bot pushed a commit that referenced this issue Nov 4, 2021
@Nowosad Nowosad closed this as completed in 79a2c2e Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants