Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add devcontainer #873

Closed
Robinlovelace opened this issue Oct 1, 2022 · 6 comments · Fixed by #874
Closed

Add devcontainer #873

Robinlovelace opened this issue Oct 1, 2022 · 6 comments · Fixed by #874
Assignees
@Robinlovelace

Comments

@Robinlovelace
Copy link
Collaborator

As described here, can support development inside our Docker container: https://code.visualstudio.com/docs/remote/containers
@Robinlovelace Robinlovelace self-assigned this Oct 1, 2022
@Robinlovelace
Copy link
Collaborator Author

After adding a devcontainer and opening the folder with Code, you get the option to open the project inside the devcontainer:

image

@Robinlovelace
Copy link
Collaborator Author

It is currently downloading the right Docker container I think.

@Robinlovelace
Copy link
Collaborator Author

image

Robinlovelace added a commit that referenced this issue Oct 1, 2022
@Robinlovelace
Add devcontainer (#873)
37ce26e
@Robinlovelace
Copy link
Collaborator Author

We need languageserver for the R package to work, plan to add it to Suggests in geocompkg: https://cran.r-project.org/web/packages/languageserver/index.html

Robinlovelace referenced this issue in geocompx/geocompkg Oct 1, 2022
@Robinlovelace
Add languageserver
8c15eb4 
See https://github.com/Robinlovelace/geocompr/issues/873
@Robinlovelace
Copy link
Collaborator Author

Update: I've reproduced the entire book in the devcontainer. It works!

image

@Robinlovelace Robinlovelace linked a pull request Oct 1, 2022 that will close this issue
873 add devcontainer #874
Merged
Robinlovelace added a commit that referenced this issue Oct 1, 2022
@Robinlovelace
Add .lintr file, improve code support (#873)
b795d8f
Robinlovelace added a commit that referenced this issue Oct 1, 2022
@Robinlovelace
Update README with devcontainers info, close #873
32d0fdd
Robinlovelace added a commit that referenced this issue Oct 1, 2022
@Robinlovelace
Add devcontainer (#873)
1fd6018
Robinlovelace added a commit that referenced this issue Oct 1, 2022
@Robinlovelace
Add .lintr file, improve code support (#873)
7ae7163
Robinlovelace added a commit that referenced this issue Oct 1, 2022
@Robinlovelace
Update README with devcontainers info, close #873
293a10c
github-actions bot pushed a commit that referenced this issue Oct 1, 2022
@Robinlovelace
Deploy commit: Update README with devcontainers info, close #873 293a10c
34210d5
@Nowosad
Copy link
Member

Nowosad commented Oct 2, 2022

👍🏻

@Robinlovelace Robinlovelace mentioned this issue Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Robinlovelace Robinlovelace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

873 add devcontainer geocompx/geocompr
2 participants
@Robinlovelace @Nowosad