Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates in raster resampling section #660

Merged
merged 4 commits into from Oct 15, 2021

Conversation

florisvdh
Copy link
Contributor

Some minor suggestions, please have a look to judge what is actually better πŸ˜‰. It's a well understandable and didactic section @Nowosad πŸ‘!

Especially check the small additional explanations in order to distinguish cubic interpolation and cubic spline interpolation - since you already added 'splines (polynomial functions)' to explain the latter. Main source is Wikipedia (and see also dsp stackexchange) since it's not explained in terra::resample(). I didn't dig further behind the scenes in terra::resample(), so best double check. BTW according to Wikipedia, there's also bicubic interpolation, used for 2D interpolation, which could be the algorithm used here (unsure).

Beside that, maybe check how the terms 'grid' and 'raster' are used in the book. I assume each has its own meaning, but better don't unnecessarily mix them, since it then seems intended and may be confusing. Cf. below extract from chapter 2, where (I think) the 'grid' term is introduced and is regarded a more general concept than 'raster'. In this PR, 'grid' is replaced by 'raster'.

The spatial raster data model represents the world with the continuous grid of cells (often also called pixels; Figure 2.10:A). This data model often refers to so-called regular grids, in which each cell has the same, constant size – and we will focus on the regular grids in this book only. However, several other types of grids exist, including rotated, sheared, rectilinear, and curvilinear grids (see Chapter 1 of E. Pebesma and Bivand (2022) or Chapter 2 of Tennekes and Nowosad (2022)).

@Nowosad
Copy link
Member

Nowosad commented Oct 15, 2021

Thank you a lot! Especially, the grid->raster change is vital.

@Nowosad Nowosad merged commit 0e8b468 into geocompx:main Oct 15, 2021
github-actions bot pushed a commit that referenced this pull request Oct 15, 2021
…ling_fv

Minor updates in raster resampling section 0e8b468
@florisvdh florisvdh deleted the geocompr_resampling_fv branch January 27, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants