Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block #664

Merged
merged 8 commits into from Oct 18, 2021
Merged

Block #664

merged 8 commits into from Oct 18, 2021

Conversation

Nowosad
Copy link
Member

@Nowosad Nowosad commented Oct 18, 2021

This PR improves our text blocks. Currently they look like this in html:

2021-10-18_09-45

With the PR we have this one for html:

2021-10-18_10-16

And this one for pdf:

2021-10-18_10-38

@@ -1,145 +1,134 @@

@misc{_map_1993,
title = {Map Projections},
date = {1993},
year = {1993},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these updates direct from Zotero? Guess happy with this, changes look good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I exported .bib from Zotero as "Better BibTeX". Should I use "Better BibLaTeX" instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think I use the same method to update the bib, will check, but this seems fine.

css: style/style.css
config:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant in the bslib version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are now using bs4_book style. Therefore, I decided to remove the old one (less problems in the future).

@@ -8,7 +8,7 @@ documentclass: krantz
monofont: "Source Code Pro"
monofontoptions: "Scale=0.7"
bibliography:
- geocompr.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we could use the .json version at some point in the future after comments in #661

@@ -78,7 +78,7 @@ If you see something like the image below, congratulations, it's worked and you
```


```{r index-2-4, echo=FALSE, fig.cap="Screenshot of reproducible code contained in Geocomputation with R running in RStudio Server on a browser served by Binder"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -44,6 +46,28 @@

\renewenvironment{Shaded}{\begin{kframe}}{\end{kframe}}

% text blocks style (e.g., background)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style looks great. How did you figure it out? Impressive!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly coping+pasting+editing and testing combination. By usual LaTeX approach;)

margin-bottom: 10px;
background: #f5f5f5 5px center/3em no-repeat;
}
.rmdcaution {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we only ever used rmdnote, so no need to keep this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. That was my thinking as well.

@Robinlovelace Robinlovelace merged commit 9a96dc2 into main Oct 18, 2021
@Robinlovelace Robinlovelace deleted the block branch October 18, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants