Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in C7, clarify a sentence in C8 #686

Merged
merged 2 commits into from Dec 2, 2021
Merged

Fix typos in C7, clarify a sentence in C8 #686

merged 2 commits into from Dec 2, 2021

Conversation

iod-ine
Copy link
Contributor

@iod-ine iod-ine commented Nov 30, 2021

The changes to chapter 7 are simple typos.

The change in chapter 8 is my attempt to make the sentence more clear. It seems like the sentence started as a comparison of ggplot2 and tmap in terms of variable aesthetics but then ended up just specifying what arguments tmap accepts. I feel like splitting these ideas makes sense.

@Nowosad Nowosad merged commit 42df99c into geocompx:main Dec 2, 2021
@Nowosad
Copy link
Member

Nowosad commented Dec 2, 2021

Thank you, Ivan!

github-actions bot pushed a commit that referenced this pull request Dec 2, 2021
Fix typos in C7, clarify a sentence in C8 42df99c
@iod-ine iod-ine deleted the typos branch December 2, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants