Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates de9im code (tmap) #690

Merged
merged 3 commits into from Dec 14, 2021
Merged

updates de9im code (tmap) #690

merged 3 commits into from Dec 14, 2021

Conversation

Nowosad
Copy link
Member

@Nowosad Nowosad commented Dec 14, 2021

No description provided.

code/de_9im.R Outdated
tm_shape(xy) +
tm_polygons("Object", legend.show = FALSE, alpha = alpha,
palette = c("#E36939", "#6673E3")) +
tm_credits(label1, position = c("left", "top")) +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: we could add #geocompr to the credits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robinlovelace -- we can consider adding #geocompr credits to some of the figures in the book explaining common ideas.

Pros: better attribution, etc.
Cons: maybe, it won't look good in the book (have you ever seen such credits in a book?)

On the other hand, we could select a few figures and create two versions -- html ones with credits and pdf ones without...

@Robinlovelace
Copy link
Collaborator

Looks good @Nowosad. I'm hesitating on merging after seeing this in the CI, guess this will resolve soon:

** testing if installed package keeps a record of temporary installation path
* DONE (sf)
Error in curl::curl_download(url, dest, handle = handle, quiet = FALSE,  : 
  Timeout was reached: [] Connection timed out after 10000 milliseconds
Calls: local ... dep_func -> read_gfont_url -> download_file -> <Anonymous>
Execution halted
Error in Rscript_render(f, render_args, render_meta, add1, add2) : 
  Failed to compile index.Rmd

@Robinlovelace Robinlovelace merged commit 50d332f into main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants