Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves s2example #746

Merged
merged 3 commits into from Feb 7, 2022
Merged

improves s2example #746

merged 3 commits into from Feb 7, 2022

Conversation

Nowosad
Copy link
Member

@Nowosad Nowosad commented Feb 6, 2022

No description provided.

@Nowosad Nowosad mentioned this pull request Feb 6, 2022
@Nowosad
Copy link
Member Author

Nowosad commented Feb 6, 2022

Maybe we should also mention maxcells somewhere, such as in india_buffer_with_s2 = st_buffer(india, 1, max_cells = 10000).

@Robinlovelace
Copy link
Collaborator

Robinlovelace commented Feb 6, 2022

Maybe we should also mention maxcells somewhere, such as in india_buffer_with_s2 = st_buffer(india, 1, max_cells = 10000).

That would duplicated content in Section 7.4. As long as people are signposted to the projections chapter they will find out there.

Copy link
Collaborator

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tm_fill(col = hcl.colors(4, palette = "purple green")[2]) +
tm_shape(india) +
tm_fill(col = "grey95") +
tm_layout(main.title = "s2 switched on")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a more explicit title, e.g.g "Buffer with distance of 1 unit when s2 is switched on, the default"

@Robinlovelace Robinlovelace merged commit 1b3e9b5 into main Feb 7, 2022
@Robinlovelace Robinlovelace deleted the new-s2-plot branch February 7, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants