New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting 3 typos and a code error #765
Conversation
`geo_df = geocode(df, address, method = "osm")` should read `geo_df = geocode(geo_df, address, method = "osm")`
Adding a missing word.
There was a dot before and after `\index{spatial operations}`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for these great changes @FlorentBedecarratsNM
@@ -52,7 +52,7 @@ Section \@ref(spatial-ras) presents spatial operations on raster datasets using | |||
Spatial subsetting is the process of taking a spatial object and returning a new object containing only features that *relate* in space to another object. | |||
Analogous to *attribute subsetting* (covered in Section \@ref(vector-attribute-subsetting)), subsets of `sf` data frames can be created with square bracket (`[`) operator using the syntax `x[y, , op = st_intersects]`, where `x` is an `sf` object from which a subset of rows will be returned, `y` is the 'subsetting object' and `, op = st_intersects` is an optional argument that specifies the topological relation (also known as the binary predicate) used to do the subsetting. | |||
The default topological relation used when an `op` argument is not provided is `st_intersects()`: the command `x[y, ]` is identical to `x[y, , op = st_intersects]` shown above but not `x[y, , op = st_disjoint]` (the meaning of these and other topological relations is described in the next section). | |||
The `filter()` function from the **tidyverse**\index{tidyverse (package)} can also be used but this approach more verbose, as we will see in the examples below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -248,7 +248,7 @@ st_within(point_sf, polygon_sfc) | |||
st_touches(point_sf, polygon_sfc) | |||
``` | |||
|
|||
Note that although the first point is *touches* the polygon, it is not within it; the third point is within the polygon but does not touch any part of its border. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi there,
Thanks again for this great resource. As suggested i #760 and in the contribution guidelines (great post by Yihui Xie referenced in the Readme by the way), I made a PR.
Best regards,
FB