repipes the book #794
Merged
repipes the book #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
🎉 to this. In the actions there's something that could cause this: https://github.com/Robinlovelace/geocompr/runs/6335806113?check_suite_focus=true#step:4:4113 Also I suggest we add |
| @@ -263,7 +263,7 @@ There are many reasons (linked to the advantages of the simple features model): | |||
| - Enhanced plotting performance | |||
| - **sf** objects can be treated as data frames in most operations | |||
| - **sf** function names are relatively consistent and intuitive (all begin with `st_`) | |||
| - **sf** functions can be combined using `%>%` operator and works well with the [tidyverse](http://tidyverse.org/) collection of R packages\index{tidyverse}. | |||
There was a problem hiding this comment.
Just noticed a typo. That should be:
- **sf** functions can be combined with the `|>` operator and works well with the [tidyverse](http://tidyverse.org/) collection of R packages\index{tidyverse}.
06-raster-vector.Rmd
Outdated
| st_sfc(crs = crs(srtm)) |> | ||
| st_sf() | ||
| st_sfc(crs = crs(srtm)) %>% | ||
| st_sf(geometry = .) |
There was a problem hiding this comment.
Why not:
st_sfc(crs = crs(srtm)) |>
st_sf(geometry = _)
?
Even if that fails on your computer it should pass on actions. I would be curious to see if it does 🤞
There was a problem hiding this comment.
Aha didn't see that, looking good 👍
Robinlovelace
approved these changes
Jun 5, 2022
05-geometry-operations.Rmd
Outdated
| @@ -464,16 +464,16 @@ plot(us_southhwest) | |||
|
|
|||
| \index{vector!geometry casting} | |||
| Geometry casting is a powerful operation that enables transformation of the geometry type. | |||
| It is implemented in the `st_cast` function from the **sf** package. | |||
| Importantly, `st_cast` behaves differently on single simple feature geometry (`sfg`) objects, simple feature geometry column (`sfc`) and simple features objects. | |||
| It is implemented in the `st_cast()` function from the **sf** package. | |||
06-raster-vector.Rmd
Outdated
| st_sfc(crs = crs(srtm)) |> | ||
| st_sf() | ||
| st_sfc(crs = crs(srtm)) %>% | ||
| st_sf(geometry = .) |
There was a problem hiding this comment.
Aha didn't see that, looking good 👍
| zion_transect = cbind(c(-113.2, -112.9), c(37.45, 37.2)) |> | ||
| st_linestring() |> | ||
| st_sfc(crs = crs(srtm)) |> | ||
| st_sf(geometry = _) |
| st_sf(data.frame(v = 1:n), geometry = .) | ||
| zion_many = st_sample(x = zion, size = n) |> | ||
| st_buffer(dist = 500) |> | ||
| st_sf(data.frame(v = 1:n), geometry = _) |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
repipes the book 3579906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.