fixes urls #990
Merged
fixes urls #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robinlovelace
approved these changes
Oct 30, 2023
| @@ -15,7 +15,7 @@ By the end of the book, we hope you will be ready to apply your skills tackle re | |||
|
|
|||
| Over the last few decades free and open source software for geospatial (FOSS4G\index{FOSS4G}) has progressed at an astonishing rate. | |||
| Thanks to organizations such as OSGeo, advanced geographic techniques are no longer the preserve of those with expensive hardware and software: anyone can now download and run high-performance software for geocomputation. | |||
| Open source Geographic Information Systems (GIS\index{GIS}), such as [QGIS](http://qgis.org/en/site/)\index{QGIS}, have made geographic analysis accessible worldwide. | |||
| Open source Geographic Information Systems (GIS\index{GIS}), such as [QGIS](https://qgis.org/en/site/)\index{QGIS}, have made geographic analysis accessible worldwide. | |||
|
|
||
| An important feature of R (and Python) is that it is an interpreted language. | ||
| This is advantageous because it enables interactive programming in a Read–Eval–Print Loop (REPL):\index{REPL} | ||
| code entered into the console is immediately executed and the result is printed, rather than waiting for the intermediate stage of compilation. | ||
| On the other hand, compiled languages such as C++\index{C++} and Java\index{Java} tend to run faster (once they have been compiled). | ||
|
|
||
| C++\index{C++} provides the basis for many GIS packages such as [QGIS](https://www.qgis.org/)\index{QGIS}, [GRASS](https://grass.osgeo.org/)\index{GRASS} and [SAGA](http://www.saga-gis.org/)\index{SAGA} so it is a sensible starting point. | ||
| C++\index{C++} provides the basis for many GIS packages such as [QGIS](https://www.qgis.org/en/site/)\index{QGIS}, [GRASS](https://grass.osgeo.org/)\index{GRASS} and [SAGA](https://saga-gis.sourceforge.io/)\index{SAGA} so it is a sensible starting point. |
There was a problem hiding this comment.
Unusual website for landing page but seems legit!
| @@ -8,7 +8,7 @@ | |||
| This is the first practical chapter of the book, and therefore it comes with some software requirements. | |||
| <!-- toDo: rl--> | |||
| <!-- should we be that specific regarding the r version?--> | |||
| You need access to a computer with a recent version of R installed (R [4.2.0](https://stat.ethz.ch/pipermail/r-announce/2022/000683.html) or a later version). | |||
| You need access to a computer with a recent version of R installed (R [4.3.0](https://stat.ethz.ch/pipermail/r-announce/2022/000683.html) or a later version). | |||
| ] | ||
| For example, think of coordinates stored in a spreadsheet format (`.csv`). | ||
| To read in such files as spatial objects, we naturally have to specify the names of the columns (`X` and `Y` in our example below) representing the coordinates. | ||
| We can do this with the help of the `options` parameter. | ||
| To find out about possible options, please refer to the 'Open Options' section of the corresponding GDAL\index{GDAL} driver description. | ||
| For the comma-separated value (csv) format, visit http://www.gdal.org/drv_csv.html. | ||
| For the comma-separated value (csv) format, visit https://gdal.org/drv_csv.html. |
There was a problem hiding this comment.
👍 our old URLs were very out of date!
Robinlovelace
approved these changes
Oct 30, 2023
13-transport.Rmd
Outdated
| @@ -513,7 +513,7 @@ Routing can be time and memory-consuming, resulting in large objects, due to the | |||
| We will therefore filter the desire lines before calculating routes in this section. | |||
|
|
|||
| Cycling is most beneficial when it replaces car trips. | |||
| Short (around 5 km, which can be cycled in 15 minutes at a speed of 20 km/hr) have a relatively high probability of being cycled, and the maximum distance increases when trips are made by [electric bike](https://www.sciencedirect.com/science/article/pii/S0967070X21003401) [@lovelace_propensity_2017]. | |||
| Short (around 5 km, which can be cycled in 15 minutes at a speed of 20 km/hr) have a relatively high probability of being cycled, and the maximum distance increases when trips are made by [electric bike](https://doi.org/10.1016/j.tranpol.2021.11.019) [@lovelace_propensity_2017]. | |||
There was a problem hiding this comment.
Marginal whether we need that URL and arguably should be reference instead if we do keep it for consistency. My bad!
There was a problem hiding this comment.
This url was found broken by the automatic system. But as you said, maybe it is not even needed and the reference could be better here.
There was a problem hiding this comment.
I suggest remove the link. There are loads of studies on E-bikes.
01-introduction.Rmd
Outdated
| This would have a large impact on existing workflows applying these packages, but also will influence the packages that depend on **rgdal**, **rgeos** or **maptools**. | ||
| Therefore, Bivand's suggestion is to transition to more modern tools, including **sf** and **terra**, as explained in this book's next chapters. | ||
| In late 2021, the planned retirement of **rgdal**, **rgeos** and **maptools** was announced on [the R-sig-Geo mailing list](https://stat.ethz.ch/pipermail/r-sig-geo/2021-September/028760.html) by Roger Bivand. | ||
| This retirement at the end of 2023 have had a large impact on existing workflows applying these packages, but also will influence the packages that depend on **rgdal**, **rgeos** or **maptools**. |
There was a problem hiding this comment.
Suggested change
| This retirement at the end of 2023 have had a large impact on existing workflows applying these packages, but also will influence the packages that depend on **rgdal**, **rgeos** or **maptools**. | |
| These packages, and packages that depended on them, were removed from CRAN at the end of 2023. |
There was a problem hiding this comment.
There's repetition of **rgdal**, **rgeos** and **maptools**.
The typo fix option:
This retirement at the end of 2023 has had ...
But I think less is better now that they have been removed.
|
I am merging it now (not to mess with the repo). I think the remaining issues at #991 can be fixes directly in the main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.