Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MaterialModel::InterfaceCompatibility #1538

Closed
3 tasks done
tjhei opened this issue May 9, 2017 · 3 comments
Closed
3 tasks done

Remove MaterialModel::InterfaceCompatibility #1538

tjhei opened this issue May 9, 2017 · 3 comments

Comments

@tjhei
Copy link
Member

tjhei commented May 9, 2017

This involves deriving MaterialModel's from MaterialModel::Interface instead of MaterialModel::InterfaceCompatibility and implementing evaluate:

  • convert tests
  • convert benchmarks/cookbooks
  • remove class
@bangerth
Copy link
Contributor

@alarshi -- can you list here the numbers of the pull requests you wrote that make this conversion? I see #1706, #1700, #1699. Did I miss any?

We like to keep track which pull requests address which issue. Ideally, pull requests list the issues they address so that github can keep track of these connections.

@gassmoeller
Copy link
Member

Resolved in a whole bunch of pull requests by @alarshi. Thanks!

@bangerth
Copy link
Contributor

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants