Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interface compatibility in the rest #1681

Closed
wants to merge 33 commits into from
Closed

Remove interface compatibility in the rest #1681

wants to merge 33 commits into from

Conversation

alarshi
Copy link
Contributor

@alarshi alarshi commented May 15, 2017

No description provided.

arushi and others added 30 commits May 14, 2017 09:17
This PR removes ifdef-ed code for deal.II 8.4.0, which we no longer support.
Add compiler flag

Add pre dealii 9 stuff

Add more functions required for pre dealii 9

Add signal

Add in actual signal

Make SpecialConeBoundary inline in compat.h

Address comments

Remove duplicate code

Address comments and clean up

Add entry changes

Update tests

Address comments
@tjhei
Copy link
Member

tjhei commented May 15, 2017

/run-tests

@tjhei
Copy link
Member

tjhei commented May 15, 2017

Awesome, this is so much nicer. As in #1679, consider editing the "author" of your commits. You also have quite a few commits including merge commits in this PR. Maybe you can squash your commits? (ask one of us for help if needed)

@tjhei
Copy link
Member

tjhei commented May 15, 2017

Also please rebase to the newest master. That should fix the test.

@tjhei
Copy link
Member

tjhei commented May 15, 2017

There are some errors, for example:

/home/dealii/source/tests/tangurnis.cc:60:65: error: ISO C++ forbids declaration of ‘evaluate’ with no type [-fpermissive]
                  MaterialModel::MaterialModelOutputs<dim> &out) const
                                                                 ^~~~~
/home/dealii/source/tests/prescribed_velocity_boundary.cc:166:54: error: ‘p’ was not declared in this scope
               const double r2 = ( pos[0] - 1.0 ) * ( p[0] - 1.0 ) + ( p[1] - 1.0 ) * ( p[1] - 1.0 )
                                                      ^

@alarshi
Copy link
Contributor Author

alarshi commented May 16, 2017

Aa oo. I just did a hard reset on my master to the development version.
I didn't test the 'tests' folder. I am making individual branches for all files and will submit pull request for each. Thank you!

@tjhei tjhei closed this May 16, 2017
@bangerth
Copy link
Contributor

In reference to #1538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants