Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-2.0 cleanups #2244

Closed
4 tasks
bangerth opened this issue May 14, 2018 · 5 comments
Closed
4 tasks

Post-2.0 cleanups #2244

bangerth opened this issue May 14, 2018 · 5 comments
Milestone

Comments

@bangerth
Copy link
Contributor

bangerth commented May 14, 2018

I can think of the following things we ought to do:

  • Require deal.II 9.0 in CMakeLists.txt
  • Document this where appropriate
  • Switch the testers to use deal.II 9.0
  • Remove #if DEAL_II_VERSION_GTE(9,0) statements.

This means we are now allowed to use C++11 -- yay!

@bangerth bangerth added this to the 2.1 milestone May 14, 2018
@tjhei
Copy link
Member

tjhei commented May 15, 2018

Does this make sense to do before the hackathon?
Pro:

  • we can hand out starter projects to do c++11 related cleanups.
  • we don't have to worry about 8.5 and 9.0 compatibility
    Cons:
  • Updating the test infrastructure (and test output) is a lot of work
  • This forces everybody to install 9.0 on their machines.

@tjhei
Copy link
Member

tjhei commented Jun 19, 2018

As a compromise: we could require c++11 (enforce in cmakelists.txt) without requiring 9.0 and start using c++11 stuff today! This would give some nice starter projects...

@bangerth
Copy link
Contributor Author

You mean continue to allow deal.II 8.5, but require C++11 anyway? That sounds fine with me.

@bangerth
Copy link
Contributor Author

We are tracking the C++11 uses in #2375.

@bangerth
Copy link
Contributor Author

We agreed to not require deal.II 9.0 at this time, so let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants