Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce AdvectionField::scalar_extractor #755

Closed
bangerth opened this issue Feb 15, 2016 · 2 comments
Closed

Introduce AdvectionField::scalar_extractor #755

bangerth opened this issue Feb 15, 2016 · 2 comments

Comments

@bangerth
Copy link
Contributor

#661 has code like this, that I suspect is repeated in other places as well:

     const FEValuesExtractors::Scalar solution_field
       = (advection_field.is_temperature()
          ?
          introspection.extractors.temperature
          :
          introspection.extractors.compositional_fields[advection_field.compositional_variable]
         );

The AdvectionField class already has a number of convenience functions that together with Introspection yield components, blocks, etc, that correspond to a particular advection field. We should also add such a function that creates an FEValues extractor to make code such as the one above simpler.

@yinghe616
Copy link
Contributor

so I think this issue is OK to close?

@bangerth
Copy link
Contributor Author

Yes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants