Introduce AdvectionField::degrees using introspection.degrees.field_name #1146
Conversation
|
This is a really nice idea that allows for a lot of simplifications. Well done! The word "degree" is so generic that it's often difficult to figure out what it means in a given context. Could you rename the structure, variable, and function PolynonialDegree and polynomial_degree, respectively? |
| }; | ||
| /** | ||
| * A variable that enumerates the base elements of the finite element | ||
| * that correspond to each of the variables in this problem. |
There was a problem hiding this comment.
Is this a comment copied from elsewhere?
There was a problem hiding this comment.
Yes, it was copied from other place. The new commit 1566b6c addressed all you early comments.
yinghe616
force-pushed
the
introspection_degree
branch
from
9a1c710
to
1566b6c
Compare
|
Yes, nice. Can you squash the two commits into one? /run-tests |
yinghe616
force-pushed
the
introspection_degree
branch
from
1566b6c
to
689a4ad
Compare
|
The two commits has been squashed into one. |
|
Ready to merge once the tester is happy. Thanks for the patch, @yinghe616 ! |
|
Ah, I want to merge, but there is a merge conflict. Can you please rebase to master? |
…omial_degree.field_name
yinghe616
force-pushed
the
introspection_degree
branch
from
689a4ad
to
1095469
Compare
Whenever we need to use the degree of polynomial of AdvectionField, we have to verify the advection field name first. This patch is the enhancement of current implementation.