fix shear heating #1032
Closed
fix shear heating #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shear heating was too large by a factor of 2. This is now fixed.
|
Let's see how many tests break. OK to merge with appropriate changes to the tests, but only after #987. |
|
I think we can close this, I double-checked with Turcotte and Schubert, and it seems to be a typo in the King et al. benchmark paper (we implement the equations in the same way as Turcotte and Schubert). I also double-checked that total shear heating and adiabatic heating are the same on the master branch. |
|
Feel like making the test you double checked the heating with into a regular test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shear heating was too large by a factor of 2. This is now fixed.