fix hanging processes when running in parallel #1075
Conversation
bjs2
commented
Jul 1, 2016
bjs2
commented
- fix a bug where processor 0 throws an exception and the other processor(s) remain stuck in a broadcast state
- make processor 0 broadcast the error and then throw an exception
- make the other processor(s) receive the error and throw an exception
- if merged, resolves issue S40RTS error in parallel #984
| MPI_Bcast(&filesize,1,MPI_UNSIGNED,0,comm); | ||
| AssertThrow (false, | ||
| ExcMessage (std::string("Could not open file <") + filename + ">.")); | ||
| return data_string; // never reached |
|
Nice, thanks for fixing the bugs I introduced 😄 |
bjs2
force-pushed
the
error_in_parallel
branch
2 times, most recently
from
1778062
to
de7ad83
Compare
|
I hope I fixed what astyle was unhappy with. It is a bit confusing at times. As for the return statements, I think Timo put those as a "just in case," although they are not needed, since throwing an exception should exit the program anyway. |
|
Ok, I am fine with either way. Just wanted to make sure somebody has thought about it 😄. Ready to merge when the tester is happy. |
- fix a bug where processor 0 throws an exception and the other processor(s) remain stuck in a broadcast state - make processor 0 broadcast the error and then throw an exception - make the other processor(s) receive the error and throw an exception
|
Sounds good. For some reason, gedit wasn't showing the tab spaces that were messing up the formatting. Weird... |
|
/run-tests |
|
@bjs2, if you're in the main directory for aspect, just call ./doc/indent and it will do all your astyle work for you! |
|
@spco "*** No astyle program found." |
|
Then you should download and compile astyle 2.04, and create a link to the binary in a place where it is found (e.g. $HOME/bin if that is in your $PATH variable). Let one of us know if you need help with it. This PR is good to go. |
|
Got it installed! :) |
