Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual fixes: alpha for thermal expansivity and more #1095

Merged
merged 2 commits into from Dec 11, 2016
Merged

Manual fixes: alpha for thermal expansivity and more #1095

merged 2 commits into from Dec 11, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2016

Added space in \times10. This supersedes #1094

lkellogg added 2 commits July 1, 2016 15:46
… Rayleigh number in Section 5.3.1, Simple convection in a quarter of a 2d annulus
@tjhei
Copy link
Member

tjhei commented Jul 1, 2016

Added space in \times10. This supersedes #1094

you don't need to open a new PR but you can update the old one by commiting and pushing.

=
\frac{10\, \text{m}\,\text{s}^{-2} \times 4\cdot 10^{-5}\text{K}^{-1} \times 3300\,
\text{K} \times 3300\, \text{kg}\,\text{m}^{-3} \times (2.86 \cdot 10^6
\text{m})^3}{10^{-6}\, \text{m}^2\,\text{s}^{-1}\times 10^{22}\,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain this change? It is somewhat hard to read without seeing the pdf. It looks like the exponent of m changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, it turns out that the only non-obvious part is the addition of the factor 10^6 m^2/s. This is because the original formula was simply missing it -- it corresponds to the thermal diffusivity kappa.

@tjhei tjhei changed the title Branchformanualupdate Manual fixes: alpha for thermal expansivity and more Jul 2, 2016
@ghost
Copy link
Author

ghost commented Jul 2, 2016

I am refining the wording in section 5.3.1. I will submit a revision when that is complete.

@tjhei
Copy link
Member

tjhei commented Jul 2, 2016

I hope you had a conversation with @bangerth about the units in the RA computation. It would be great to continue that equation and provide an estimate for the RA number.

@bangerth
Copy link
Contributor

bangerth commented Jul 3, 2016

Yes, we talked about it. I gave @lkellogg permission to do with the section as she pleases because she was clearly right :-)

@bangerth
Copy link
Contributor

bangerth commented Aug 2, 2016

@lkellogg -- any progress here? We'd love to have you as an author ;-)

@bangerth
Copy link
Contributor

See also #1304.

@bangerth
Copy link
Contributor

Also see #989.

@bangerth
Copy link
Contributor

I think that upon taking a closer look, this is actually correct.

@bangerth bangerth merged commit bb75f45 into geodynamics:master Dec 11, 2016
@ghost ghost deleted the branchformanualupdate branch December 11, 2016 01:21
bangerth added a commit to bangerth/aspect that referenced this pull request Dec 11, 2016
This is entirely justified following the merge of geodynamics#1095.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants