Improvement of the matrix sparsity pattern of DG on single core #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (parameters.use_discontinuous_temperature_discretization | ||
| && parameters.use_limiter_for_discontinuous_temperature_solution) | ||
| apply_limiter_to_dg_solutions(AdvectionField::temperature()); | ||
|
|
There was a problem hiding this comment.
This change is independent of the other one. Can you separate this into a different pull request?
|
/run-tests |
| constraints, false, | ||
| Utilities::MPI:: | ||
| this_mpi_process(mpi_communicator)); | ||
| DoFTools::make_flux_sparsity_pattern (dof_handler, |
There was a problem hiding this comment.
you don't need to run both functions, just make_flux_sparsity_pattern should do both.
There was a problem hiding this comment.
oh, or do you need this because of the constraints?
There was a problem hiding this comment.
Yes, for the constraints. Otherwise, it gives run-error messages.
This was referenced Jul 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two changes:
for single core, call the make_flux_sparsity_pattern for DG with face coupling, which has less nonzero numbers; for multiple cores, call the make_flux_sparsity_pattern for DG with face coupling at every where, but it allows to use multiple processor.
move the DG BP limiter to the solver.cc inside the function call of solve_advection.
@egpuckett