fixes to compile without cxx11 #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tjhei
commented
Nov 3, 2016
tjhei
commented
- boost::scoped_ptr can not be returned from a function
- std::multimap::insert(hint) takes a non-const iterator pre cxx11
1. boost::scoped_ptr can not be returned from a function 2. std::multimap::insert(hint) takes a non-const iterator pre cxx11
bangerth
reviewed
Nov 3, 2016
| std_cxx11::unique_ptr<Mapping<dim> > construct_mapping(const GeometryModel::Interface<dim> &geometry_model, | ||
| const InitialTopographyModel::Interface<dim> &initial_topography_model) | ||
| Mapping<dim> *construct_mapping(const GeometryModel::Interface<dim> &geometry_model, | ||
| const InitialTopographyModel::Interface<dim> &initial_topography_model) |
There was a problem hiding this comment.
Ah, bummer. We went around this so many times to make the semantics obvious when @gassmoeller implemented it. It is so elegant with the unique-ptr...
There was a problem hiding this comment.
Yeah. The problem is that scoped_ptr is not a drop-in replacement for unique_ptr. We could have switched to a shared_ptr here, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.