Remove deprecated heating parameters from input files #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
changed the title
|
I updated the cookbooks and removed comments that referenced the now gone/moved parameters. Ready for review. |
bangerth
requested changes
Dec 1, 2016
| without this simplification. | ||
| to the total pressure. \aspect{} therefore by default implements the original | ||
| term without this simplification, but allows to simplify this term by setting | ||
| the \textit{Use simplified adiabatic heating} |
There was a problem hiding this comment.
We seem to consistently use \texttt for parameter names.
Would it also be worthwhile adding a link to the corresponding section of this parameter?
|
Looks good to me. |
gassmoeller
force-pushed
the
replace_heating_parameters
branch
from
c43be6d
to
411fa6d
Compare
|
I made the change. Could someone take a look if the manual compiles without error? I currently have no access to the special packages we use, and the syntax is a bit obscure. Otherwise ready from my side. |
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated heating parameters (since Hackathon 2015) from all our input files. The options itself for now stay in the code. I am in favor of removing them after the next release. The changes were done by a script, and I need to test first if any tests break. Also some input files will now have comments that reference parameters that are not longer in the input files, and I need to take a look at all of those .part. ... files. Not ready for review yet.