New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global statistics postprocessor #1463
Conversation
162cbb0
to
3ad5899
Compare
0ff216c
to
5a33217
Compare
This should be ready for review/merge. For earlier comments that are addressed see #1429. |
source/simulator/solver.cc
Outdated
#if DEAL_II_VERSION_GTE(9,0,0) | ||
SolverControl solver_control (1000, tolerance); | ||
#else | ||
ExtendedSolverControl solver_control (1000, tolerance); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You no longer need the distinction here (i.e., just use SolverControl
unconditionally) because for old versions of deal.II, writing SolverControl
finds the declaration in namespace aspect
, whereas for new versions of deal.II, it just takes the one in namespace dealii
because there is none in the "closer namespace" aspect
.
include/aspect/compat.h
Outdated
|
||
namespace dealii | ||
{ | ||
class ExtendedSolverControl : public SolverControl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just say
namespace aspect {
class SolverControl : public dealii::SolverControl
and you won't need the typedef below any more :-)
I addressed the comments, and it seems to work. Dont know why it did not work the first time I tried it that way. Anyway, should be ready to merge now. |
d13dd8e
to
49cd1b9
Compare
This PR broke mainline:
|
On it. |
This is a rebase from #1429. I will need to adjust the test outputs because of our switch to the 8.5 tester.