Add a field to Introspection to query the number of compositional fields. #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-tests |
|
The tester is having the same problem as always, but I think the patch is ok. But since I worked on this with @pmbremner I'd prefer if someone else took a look. |
tjhei
requested changes
May 8, 2017
source/simulator/introspection.cc
Outdated
| @@ -173,6 +173,7 @@ namespace aspect | |||
| : | |||
| FEVariableCollection<dim>(variable_definition), | |||
| n_components (FEVariableCollection<dim>::n_components()), | |||
| n_compositional_fields (n_components-dim-2), | |||
There was a problem hiding this comment.
please use parameters.names_of_compositional_fields.size() instead. I think this can break with melt and/or other additional equations the way you did this.
pmbremner
force-pushed
the
add-field-to-introspection
branch
from
9f8028d
to
dfd7975
Compare
|
Made suggested change. Please have a look |
bangerth
reviewed
May 8, 2017
source/simulator/introspection.cc
Outdated
| @@ -173,6 +173,7 @@ namespace aspect | |||
| : | |||
| FEVariableCollection<dim>(variable_definition), | |||
| n_components (FEVariableCollection<dim>::n_components()), | |||
| n_compositional_fields (parameters.names_of_compositional_fields.size()), | |||
There was a problem hiding this comment.
why not use parameters.n_compositional_fields as the initializer?
|
@pmbremner -- would you mind addressing the one comment? |
pmbremner
force-pushed
the
add-field-to-introspection
branch
from
dfd7975
to
88256ed
Compare
tjhei
approved these changes
May 9, 2017
|
I see a test failed, but it's not clear how this patch affects it. What to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.