Add distance to polygon function #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
May 10, 2017
include/aspect/utilities.h
Outdated
| @@ -141,6 +141,15 @@ namespace aspect | |||
| const dealii::Point<2> &point); | |||
|
|
|||
| /** | |||
| * Given a 2d point and a list of points which form a polygon, compute the smallest | |||
| * distance of the point to the polygon. | |||
There was a problem hiding this comment.
can you add how the sign is defined, namely positive if the point is inside, and negative if outside?
Fix bug Add acknowledgements Add test Improve comment
anne-glerum
force-pushed
the
distance_to_polygon
branch
from
c99f03a
to
51012f9
Compare
|
Great, I've updated the comments and the test is already included. |
|
/run-tests Yes, I saw the test. I just wanted to express my appreciation for you adding it right from the start :-) OK to merge once the tester is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it needed a test, but out of curiosity I made one of this type.