Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-convex polygons to test and remove statement #1567

Merged
merged 1 commit into from May 12, 2017
Merged

Add non-convex polygons to test and remove statement #1567

merged 1 commit into from May 12, 2017

Conversation

anne-glerum
Copy link
Contributor

No description provided.

@bangerth
Copy link
Contributor

Changed your mind about the need for convexity? ;-)

You'll have to indent, and update the test output.

@bangerth
Copy link
Contributor

/run-tests

@anne-glerum
Copy link
Contributor Author

Indeed, sorry!

@gassmoeller
Copy link
Member

So the algorithm is already correct for concave polygons, and we were just missing a test? If so, this is ready to merge.

@anne-glerum
Copy link
Contributor Author

Yes it's correct for concave polygons.

@gassmoeller gassmoeller merged commit 891c4e6 into geodynamics:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anne-glerum @bangerth @gassmoeller