allow ascii data reference profile material model to output seismic v… #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdannberg
force-pushed
the
burnman_seismic_velocities
branch
from
a24ea2a
to
3a0b4f1
Compare
tjhei
requested changes
May 10, 2017
| @@ -107,6 +107,11 @@ namespace aspect | |||
| * @} | |||
| */ | |||
|
|
|||
| virtual | |||
There was a problem hiding this comment.
add a comment "add named outputs for seismic properties"
| catch (...) | ||
| { | ||
| // keep the invalid unsigned int entry if the columns do not exist, | ||
| // we'll handle this below when we fill the outputs |
There was a problem hiding this comment.
so what if some of the columns exist? I guess you would only see them if you find them in the correct order. Hrm, not sure if that is important.
There was a problem hiding this comment.
I added a new function to utilities that returns an invalid unsigned int if the column does not exist (individually for every column name I use it with).
tests/burnman_seismic_test.prm
Outdated
| @@ -0,0 +1,150 @@ | |||
| # A cookbook for using seismic velocity data | |||
There was a problem hiding this comment.
update to say what it is based on and that you test seismic output
| ----------------------------------------------------------------------------- | ||
| ----------------------------------------------------------------------------- | ||
|
|
||
| Ascii data file coordinates are not equidistant. |
jdannberg
force-pushed
the
burnman_seismic_velocities
branch
from
3a0b4f1
to
a57f69a
Compare
jdannberg
force-pushed
the
burnman_seismic_velocities
branch
from
a57f69a
to
5b2d5d3
Compare
|
I think I addressed all of you comments, even the one with the ugly warning 😃 |
|
@tjhei: Your time to press the merge button 😄 |
1 similar comment
|
@tjhei: Your time to press the merge button 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…elocities