New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests for annulus & hollow_sphere benchmarks #1598
tests for annulus & hollow_sphere benchmarks #1598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Two comments about simplifying the plugins.
tests/annulus.cc
Outdated
@@ -0,0 +1,562 @@ | |||
#include <aspect/material_model/simple.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is a copy of the file in benchmarks, please use a #include ../benchmarks/.../...cc
instead. That way we can test the actual code in benchmarks.
tests/hollow_sphere.cc
Outdated
@@ -0,0 +1,696 @@ | |||
#include <aspect/material_model/simple.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above
/run-tests |
Testing also failed -- might have to update the test output |
yes, and rebase to the current master to fix the geoid test |
18cc77a
to
fe378d3
Compare
…ake_tests_for_my_benchmarks
tests/hollow_sphere.prm
Outdated
# run at the end of each time step. | ||
|
||
subsection Postprocess | ||
set List of postprocessors = visualization, velocity statistics, HollowSpherePostprocessor, depth average, memory statistics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the memory postprocessor and update the results for both tests, please? The number is unlikely to be very stable.
I think Timo's comment was hidden by other changes, but could you remove the memory statistics postprocessor and update the tests? This number might change. |
I did this yesterday evening |
Sorry, looked at the prm files for the benchmark folder, not the tests. Good to go. |
No description provided.