Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for annulus & hollow_sphere benchmarks #1598

Merged
merged 6 commits into from May 15, 2017

Conversation

cedrict
Copy link
Contributor

@cedrict cedrict commented May 12, 2017

No description provided.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two comments about simplifying the plugins.

tests/annulus.cc Outdated
@@ -0,0 +1,562 @@
#include <aspect/material_model/simple.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a copy of the file in benchmarks, please use a #include ../benchmarks/.../...cc instead. That way we can test the actual code in benchmarks.

@@ -0,0 +1,696 @@
#include <aspect/material_model/simple.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

@gassmoeller
Copy link
Member

/run-tests

@bangerth
Copy link
Contributor

Testing also failed -- might have to update the test output

@tjhei
Copy link
Member

tjhei commented May 13, 2017

yes, and rebase to the current master to fix the geoid test

@cedrict cedrict force-pushed the make_tests_for_my_benchmarks branch from 18cc77a to fe378d3 Compare May 13, 2017 19:56
# run at the end of each time step.

subsection Postprocess
set List of postprocessors = visualization, velocity statistics, HollowSpherePostprocessor, depth average, memory statistics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the memory postprocessor and update the results for both tests, please? The number is unlikely to be very stable.

@gassmoeller
Copy link
Member

I think Timo's comment was hidden by other changes, but could you remove the memory statistics postprocessor and update the tests? This number might change.

@cedrict
Copy link
Contributor Author

cedrict commented May 15, 2017

I did this yesterday evening

@gassmoeller
Copy link
Member

Sorry, looked at the prm files for the benchmark folder, not the tests. Good to go.

@gassmoeller gassmoeller merged commit edbe5c4 into geodynamics:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants