simplifying the code in the other source files under the refinement folder #1665
Conversation
|
|
||
| // Scale gradient in each cell with the correct power of h. Otherwise, | ||
| // error indicators do not reduce when refined if there is a density | ||
| // jump. We need at least order 1 for the error not to grow when | ||
| // refining, so anything >1 should work. (note that the gradient | ||
| // itself scales like 1/h, so multiplying it with any factor h^s, s>1 | ||
| // will yield convergence of the error indicators to zero as h->0) | ||
| indicators[i] *= std::pow(cell->diameter(), power); |
There was a problem hiding this comment.
Is this the same logic as before? It looks like we would scale indicators[i] several times here before. I think the new logic is correct and the old one is incorrect for more than one field.
There was a problem hiding this comment.
ahh..., only this one is different than others. :D It was mentioned as in issue #1659
There was a problem hiding this comment.
Yes, the old logic was incorrect, see #1659.
|
Looks good. /run-tests |
|
okay, can you adjust the test output then? |
|
We have one test that now produces different output, and it is exactly the one we suspected -- Maybe as a general rule: if you fix one issue, and then do a bunch of other simplifications, it's often useful to do so in separate pull requests. This way the uncontroversial parts can easily be committed, and we can discuss the bug fixes separately from the rest. |
YHUCD
force-pushed
the
simplify_composition_refinement
branch
from
4516bba
to
ed77759
Compare
|
ok. I just recovered composition_gradient.cc and removed from this Patch. I'll open a different pull request with a new test example results. I was totally forgot that it could be possible to give a different results than before. :D |
I didn't change any functionality or logic of those code. When I wrote the new mesh refinement composition_approximate_gradient.cc, just looked around other sources files in the same folder, and I found that some of those codes can also be simplified.