Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MaterialModelInputs<dim>::reinit() where appropriate. #1689

Merged
merged 1 commit into from May 16, 2017

Conversation

ian-r-rose
Copy link
Contributor

This uses the new MaterialModelInputs::reinit() function of @pmbremner in a bunch of places.

@bangerth
Copy link
Contributor

/run-tests

Not all of these places fill all variables, but they will do so now. This may not be what is intended. Specifically, filling the strain rate implies having to compute the viscosity -- which is often expensive. Thoughts?

@ian-r-rose
Copy link
Contributor Author

Yes, that is a point of contention. I think that the assumption that only viscosity depends on strain rates is not necessarily a good one, and would advocate deprecating it. It would not be hard to add a bool flag to toggle whether to fill the strain rates, which would kick the can on that particular discussion. cc @tjhei @bobmyhill

@tjhei
Copy link
Member

tjhei commented May 15, 2017

Yes, that is a point of contention. I think that the assumption that only viscosity depends on strain rates is not necessarily a good one

We should discuss.

@ian-r-rose ian-r-rose force-pushed the use_material_model_reinit branch 2 times, most recently from 7894117 to 8012d46 Compare May 15, 2017 22:00
@bobmyhill
Copy link
Member

I'm on @ian-r-rose's side.

@bobmyhill
Copy link
Member

(but yes, we should discuss!)

@ian-r-rose
Copy link
Contributor Author

I have restored the ability to select whether or not to compute strain rates, so this should be good to go.

@bangerth bangerth merged commit 32ae628 into geodynamics:master May 16, 2017
@bangerth
Copy link
Contributor

Outstanding -- thank you! Feel free to open an issue to discuss the question of not always computing the viscosity/not always passing the strain rate.

@ian-r-rose ian-r-rose deleted the use_material_model_reinit branch May 16, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants