move and rename extract_component_subset #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
force-pushed
the
move_extract_component_subset
branch
from
67d7aad
to
709b6b9
Compare
bangerth
reviewed
May 16, 2017
source/simulator/introspection.cc
Outdated
| // is simple and we can just associate it with | ||
| // what system_to_component_index gives us | ||
| for (unsigned int i=0; i<fe.dofs_per_cell; ++i) | ||
| if (fe.is_primitive(i)) |
There was a problem hiding this comment.
are we ever using non-primitive elements? we could avoid a lot of complexity if we assume that
source/simulator/introspection.cc
Outdated
| /** | ||
| * This is an internal deal.II function stolen from dof_tools.cc | ||
| */ | ||
| template <int dim, int spacedim> |
There was a problem hiding this comment.
can you add the deal.II documentation of the function here?
source/simulator/introspection.cc
Outdated
|
|
||
| template <int dim> | ||
| IndexSet extract_component_subset(const DoFHandler<dim> &dof_handler, | ||
| const ComponentMask &component_mask) |
There was a problem hiding this comment.
I don't like the name. Can we call it extract_dofs_for_component_subset() or something?
tjhei
force-pushed
the
move_extract_component_subset
branch
2 times, most recently
from
bb95b3c
to
b35629a
Compare
tjhei
changed the title
|
addressed your comments |
|
OK. |
tjhei
force-pushed
the
move_extract_component_subset
branch
from
b35629a
to
17c5354
Compare
tjhei
force-pushed
the
move_extract_component_subset
branch
from
17c5354
to
eafb313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change functionality but allows me to use the function in other .cc files later.